Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Make aside label canbe translate. #476

Closed
wants to merge 1 commit into from
Closed

[WIP] Make aside label canbe translate. #476

wants to merge 1 commit into from

Conversation

liruifengv
Copy link
Member

What kind of changes does this PR include?

  • Changes to Starlight code

Description

  • Make aside label canbe translate.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

⚠️ No Changeset found

Latest commit: 5132831

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Aug 9, 2023 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 5132831
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64d33f04fa612d0007bd83b6
😎 Deploy Preview https://deploy-preview-476--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Aug 9, 2023
delucis
delucis reviewed Aug 13, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking off this work @liruifengv! Let me know when you’re ready for feedback or if you have questions 🙌

@liruifengv liruifengv closed this Aug 15, 2023
@liruifengv liruifengv deleted the asides-i18n branch August 15, 2023 01:16
@liruifengv liruifengv restored the asides-i18n branch August 15, 2023 01:16
@liruifengv liruifengv mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis left review comments

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liruifengv @delucis